Open
Conversation
Implements a pure Ruby filesystem blobstore client as an alternative to fog-local. This provides a lightweight, dependency-free option for local development and testing environments. Key changes: - Add LocalClient and LocalBlob classes in lib/cloud_controller/blobstore/local/ - Update ClientProvider to support 'local' and 'local-temp-storage' blobstore types - Add 'blobstore_type' configuration option to all config schemas (api, worker, clock, deployment_updater, blobstore_benchmarks) - Update config/cloud_controller.yml to use local-temp-storage as default - Add comprehensive specs for LocalClient and LocalBlob - LocalClient matches fog-local behavior including parent directory cleanup The LocalClient implementation: - Stores blobs as files in a configurable directory - Supports all standard blobstore operations (exists?, cp_to_blobstore, download_from_blobstore, delete, etc.) - Automatically creates parent directories and cleans up empty ones on delete - Uses consistent logging with 'blobstore.cp-start/finish/skip' prefixes - Thread-safe file operations This enables simpler local development workflows without requiring S3-compatible services or fog-local gem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a pure Ruby filesystem blobstore client as an alternative to fog-local. This provides a lightweight, dependency-free option for local development and testing environments.
Key changes:
The LocalClient implementation:
Config parameters:
blobstore_type: localorblobstore_type: local-temp-storagelocal_blobstore_path: Base directory (only forblobstore_type: local)This enables simpler local development workflows without requiring S3-compatible blobstore or fog-local gem.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests